Skip to content

Tests: Make some number comparisons less strict#1947

Merged
mgol merged 1 commit into
jquery:mainfrom
mgol:less-strict-comparisons
Mar 8, 2021
Merged

Tests: Make some number comparisons less strict#1947
mgol merged 1 commit into
jquery:mainfrom
mgol:less-strict-comparisons

Conversation

@mgol
Copy link
Copy Markdown
Member

@mgol mgol commented Mar 7, 2021

Some of the APIs return fractional values in newer jQueries, making comparisons
sometimes not being 100% accurate. Allow some delta.

This is similar to what was already done in
98b5391 but a few cases affecting IE and/or
Edge Legacy were missed.

Some of the APIs return fractional values in newer jQueries, making comparisons
sometimes not being 100% accurate. Allow some delta.

This is similar to what was already done in
98b5391 but a few cases affecting IE and/or
Edge Legacy were missed.
@mgol mgol added this to the 1.13 milestone Mar 7, 2021
@mgol mgol requested review from arschmitz and fnagel March 7, 2021 13:02
Copy link
Copy Markdown
Member

@fnagel fnagel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 by reading

@mgol mgol merged commit 9ea690a into jquery:main Mar 8, 2021
@mgol mgol deleted the less-strict-comparisons branch March 8, 2021 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants