Skip to content

Build: Don't save temporary npm dependencies to package.json, update release deps #1966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 6, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build/release-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ script( Release );

// Ignores actual version installed, should be good enough for a test
if ( shell.exec( "npm ls --depth 0 | grep download.jqueryui.com" ).code === 1 ) {
shell.exec( "npm install " + script.dependencies.join( " " ) );
shell.exec( "npm install --no-save " + script.dependencies.join( " " ) );
}

// If AUTHORS.txt is outdated, this will update it
Expand Down
6 changes: 3 additions & 3 deletions build/release.js
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,8 @@ function addManifest( packager ) {
function buildCDNPackage( callback ) {
console.log( "Building CDN package" );
var JqueryUi = require( "download.jqueryui.com/lib/jquery-ui" );
var PackageWithoutThemes = require( "download.jqueryui.com/lib/package-1-12" );
var PackageOfThemes = require( "download.jqueryui.com/lib/package-1-12-themes" );
var PackageWithoutThemes = require( "download.jqueryui.com/lib/package-1-13" );
var PackageOfThemes = require( "download.jqueryui.com/lib/package-1-13-themes" );
var Packager = require( "node-packager" );

// PackageOfThemes doesn't contain JS files, PackageWithoutThemes doesn't contain themes;
Expand Down Expand Up @@ -136,7 +136,7 @@ Release.define( {
};

module.exports.dependencies = [
"download.jqueryui.com@2.1.27",
"download.jqueryui.com@2.2.0",
"node-packager@0.0.6",
"shelljs@0.8.4"
];