Skip to content

Add workaround for button outline problem in FF 78+#2010

Closed
flack wants to merge 1 commit into
jquery:mainfrom
flack:patch-1
Closed

Add workaround for button outline problem in FF 78+#2010
flack wants to merge 1 commit into
jquery:mainfrom
flack:patch-1

Conversation

@flack
Copy link
Copy Markdown

@flack flack commented Nov 8, 2021

Add a workaround for a problem where the close button outline is wrong in Firefox > 77

fixes #2003

@linux-foundation-easycla
Copy link
Copy Markdown

CLA Not Signed

@flack
Copy link
Copy Markdown
Author

flack commented Nov 8, 2021

I clicked through a couple of pages of this CLA stuff, but honestly all this legal crap is a bit too annoying for me. So I hereby grant anyone interested permission to re-submit this patch under their own name. If no one is interested, this PR can be closed

@fnagel
Copy link
Copy Markdown
Member

fnagel commented Nov 8, 2021

@brianwarner Can you help out here with the CLA stuff? Thanks!

@brianwarner
Copy link
Copy Markdown

Thanks for your contribution, @flack. I see it's a one-liner, but unfortunately under the IP policy we can't really do much without a signed CLA.

@flack
Copy link
Copy Markdown
Author

flack commented Nov 11, 2021

Good news, it looks like this is getting fixed in Firefox instead: https://hg.mozilla.org/mozilla-central/rev/1b335acf7f13

@flack flack closed this Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

Wrong outline in dialog close button on Firefox

3 participants