Resizable: Fix resizing of elems with box-sizing: border-box

[mcanepa]

fixes #1979

[linux-foundation-easycla]

The committers are authorized under a signed CLA.

• ✅ Matías Cánepa (5101f17)

[mgol]

We had broken CI for a while. Please rebase to the latest main so that GitHub Actions run on the PR.

We'll also need unit tests for the change and I'll need some time to understand what's exactly going on here; although, if you could add comments on GitHub explaining the code changes, that'd speed things up.

[mgol]

If you're interested in finishing this, there are some existing autoResize tests in tests/unit/resizable/options.js, you'd need to add a new test there.

[mcanepa]

I'll try my best...

This will be my first encounter with a unit test so any help from anyone it would be very much appreciated

[mgol]

It's best to look at existing tests and do something similar. Of course, feel free to ask questions.

[mcanepa]

@mgol just added a test. I hope it's ok!

[mcanepa]

hello @mgol @fnagel

Any chance for this issue to be reviewed?

[mgol]

See my comments. Please also merge the latest main to your branch. When that gets addressed, I'll approve the PR.

@fnagel do you have any other concerns or are you also OK with landing this after my remarks are addressed?

[mgol]

Thank you! Looks good to me now. I'll still wait a bit for @fnagel's review before merging.

[fnagel]

+1 by reading

[mgol]

Landed, thanks!