Tabs: added keyboard accessibility. Fixes #3079. Tabs were not accessible

[eikes]

Tabs: added keyboard accessibility. Fixes #3079. Tabs were not accessible

[gnarf]

Please take a look at our coding standards there are a few issues I noticed quickly.

• Missing empty line before comments
• Multiple var statements in one function.
• Tabs on empty lines ( empty lines should be empty, void of tabs )

Also, not sure if you looked at the tabs accessibility requirements on the planning wiki or not, but I don't think you have followed them.

[eikes]

Can you be more specific as to what parts of the accessibility requirements you think have been met? As far as I can tell all the keyboard interactions as described in "4.4 Accessibility recommendations / Keyboard Accessibility" are implemented, because that's what I used as requirements when implementing it, thus fixing the issue described in the bug tracker.

Cleaning the code is of course no problem, but functionality should be discussed first I think.

[gnarf]

• The entire section of key events while inside tabs.
• The alt+del functionality.
• "enter"

[scottgonzalez]

Thanks, but we're going to wait on adding keyboard accessibility until we can discuss this more. We're considering having delayed activation of tabs as well.