fixup! PR feedback

.github/workflows/node.js.yml

@@ -6,17 +6,18 @@ on:
     branches-ignore: "dependabot/**"
   # Once a week every Monday
   schedule:
-    - cron: "0 0 * * 1"
+    - cron: "42 1 * * 1"
 
 permissions:
   contents: read
 
+env:
+  NODE_VERSION: 20.x
+
 jobs:
   build-and-test:
     runs-on: ubuntu-latest
     name: ${{ matrix.BROWSER }} - jQuery ${{ matrix.JQUERY }}
-    env:
-      NODE_VERSION: 20.x
     strategy:
       fail-fast: false
       matrix:
@@ -60,8 +61,6 @@ jobs:
   edge:
     runs-on: windows-latest
     name: edge - jQuery ${{ matrix.JQUERY }}
-    env:
-      NODE_VERSION: 20.x
     strategy:
       fail-fast: false
       matrix:
@@ -100,8 +99,6 @@ jobs:
   safari:
     runs-on: macos-latest
     name: safari - jQuery ${{ matrix.JQUERY }}
-    env:
-      NODE_VERSION: 20.x
     strategy:
       fail-fast: false
       matrix:

tests/index.html

@@ -18,7 +18,7 @@ <h2>Unit Tests</h2>
 		<p><a href="unit/index.html">Unit tests</a> exist for all functionality in jQuery UI.
 		The unit tests can be run locally (some tests require a web server with PHP)
 		to ensure proper functionality before committing changes.
-		The unit tests are also run in Chrome, Firefox, and Safari on every commit.</p>
+		The unit tests are also run in Chrome, Firefox, Edge, and Safari on every commit.</p>
 
 		<h2>Visual Tests</h2>
 		<p><a href="visual/index.html">Visual tests</a> only exist in cases where we can't verify proper functionality

tests/runner/.eslintrc.json

@@ -11,7 +11,8 @@
 			},
 			"globals": {
 				"fetch": false,
-				"Promise": false
+				"Promise": false,
+				"require": false
 			},
 			"parserOptions": {
 				"ecmaVersion": 2022,
@@ -21,7 +22,8 @@
 		{
 			"files": ["./listeners.js"],
 			"env": {
-				"browser": true
+				"browser": true,
+				"node": false
 			},
 			"globals": {
 				"QUnit": false,

tests/runner/command.js

@@ -29,6 +29,12 @@ const argv = yargs( process.argv.slice( 2 ) )
 			"Pass multiple versions by repeating the option.",
 		default: [ "3.7.1" ]
 	} )
+	.option( "migrate", {
+		type: "boolean",
+		description:
+			"Run tests with jQuery Migrate enabled.",
+		default: false
+	} )
 	.option( "browser", {
 		alias: "b",
 		type: "array",
@@ -57,10 +63,6 @@ const argv = yargs( process.argv.slice( 2 ) )
 		type: "number",
 		description: "Run tests in parallel in multiple browsers. Defaults to 8."
 	} )
-	.option( "run-id", {
-		type: "string",
-		description: "A unique identifier for this run."
-	} )
 	.option( "verbose", {
 		alias: "v",
 		type: "boolean",

tests/runner/lib/buildTestUrl.js

@@ -1,4 +1,4 @@
-export function buildTestUrl( suite, { jquery, port, reportId } ) {
+export function buildTestUrl( suite, { jquery, migrate, port, reportId } ) {
 	if ( !port ) {
 		throw new Error( "No port specified." );
 	}
@@ -9,6 +9,10 @@ export function buildTestUrl( suite, { jquery, port, reportId } ) {
 		query.append( "jquery", jquery );
 	}
 
+	if ( migrate ) {
+		query.append( "migrate", "true" );
+	}
+
 	if ( reportId ) {
 		query.append( "reportId", reportId );
 	}

tests/runner/listeners.js

@@ -56,6 +56,9 @@
 			// Serialize Symbols as string representations so they are
 			// sent over the wire after being stringified.
 			if ( typeof value === "symbol" ) {
+
+				// We can *describe* unique symbols, but note that their identity
+				// (e.g., `Symbol() !== Symbol()`) is lost
 				var ctor = Symbol.keyFor( value ) !== undefined ? "Symbol.for" : "Symbol";
 				return ctor + "(" + JSON.stringify( value.description ) + ")";
 			}

tests/runner/reporter.js

@@ -114,12 +114,13 @@ export function reportTest( test, reportId, { browser, headless } ) {
 	}
 }
 
-export function reportEnd( result, reportId, { browser, headless, jquery, suite } ) {
+export function reportEnd( result, reportId, { browser, headless, jquery, migrate, suite } ) {
 	const fullBrowser = getBrowserString( browser, headless );
 	console.log(
 		`\n\nTests finished in ${ prettyMs( result.runtime ) } ` +
 			`for ${ chalk.yellow( suite ) } ` +
 			`and jQuery ${ chalk.yellow( jquery ) } ` +
+			( migrate ? `with ${ chalk.yellow( "jQuery Migrate enabled " ) }` : "" ) +
 			`in ${ chalk.yellow( fullBrowser ) } (${ chalk.bold( reportId ) })...`
 	);
 	console.log(

tests/runner/run.js

@@ -18,10 +18,10 @@ export async function run( {
 	browser: browserNames = [],
 	concurrency,
 	debug,
-	jquery: jquerys = [],
 	headless,
+	jquery: jquerys = [],
+	migrate,
 	suite: suites = [],
-	runId,
 	verbose
 } ) {
 	if ( !browserNames.length ) {
@@ -45,11 +45,6 @@ export async function run( {
 	// Convert browser names to browser objects
 	let browsers = browserNames.map( ( b ) => ( { browser: b } ) );
 
-	// A unique identifier for this run
-	if ( !runId ) {
-		runId = generateHash( `${ Date.now() }-${ suites.join( ":" ) }` );
-	}
-
 	// Create the test app and
 	// hook it up to the reporter
 	const reports = Object.create( null );
@@ -153,10 +148,11 @@ export async function run( {
 
 		for ( const jquery of jquerys ) {
 			const reportId = generateHash( `${ suite } ${ fullBrowser }` );
-			reports[ reportId ] = { browser, headless, jquery, suite };
+			reports[ reportId ] = { browser, headless, jquery, migrate, suite };
 
 			const url = buildTestUrl( suite, {
 				jquery,
+				migrate,
 				port,
 				reportId
 			} );
@@ -165,8 +161,8 @@ export async function run( {
 				debug,
 				headless,
 				jquery,
+				migrate,
 				reportId,
-				runId,
 				suite,
 				verbose
 			};
@@ -182,7 +178,6 @@ export async function run( {
 	}
 
 	try {
-		console.log( `Starting Run ${ runId }...` );
 		await runAll( { concurrency, verbose } );
 	} catch ( error ) {
 		console.error( error );