Untitled #25
Closed
Untitled #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t in opera. Fixed #6055 (keyDown event doesn't prevent form from submit)
…. Move suppressKeyPress declaration to the upper scope
|
Here is the fix. i'm not very familiar with github system, so tell me, if I need to do something else with the pull request |
|
Thanks, I'll test this out in a few browsers tomorrow. There's still the potential for keydown and keypress to be out of sync (press two keys down before releasing), but that's pretty uncommon and shouldn't be a concern for the enter key. |
|
Thanks, landed in c3b282f. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for bug #6055 (keyDown event doesn't prevent form from submit) in autocomplete. Updated according to comments in this request - http://github.com/jquery/jquery-ui/pull/13