Fixed #6242

[dcneiner]

Button: no longer calls _resetButton() after changing the disabled option. Fixed #6242 - Button .enable() strange behavior on Webkit (Google Chrome, Safari)

---

The call to _resetButton during the mouse events was causing the problem. However, _resetButton does not respond to the enabled or disabled state of the button in any way. However, setting this option was used to trigger reset on create, so I added the explicit call to _resetButton under the _setOption call at the end of the _create method.

All unit tests for button are still passing with these changes.

Demo of both broken and fixed version of the code: http://jsbin.com/ohene4/9

[jzaefferer]

Could you try and add a test that actually fails without the moidification? THat way we'll have an actual regression test.

[dcneiner]

I just tried to write a unit test, but I don't think it can be done. The change of state has to happen between mousedown and mouseup of the click event for the bug to appear. With the current simulate plugin, simply simulating mousedown then mouseup does not trigger a click -- and simulating a click after those two actions does not reveal the same problem.

[dcneiner]

More info: It breaks because when _resetButton() is called, it replaces the span that the mousedown was originally fired on. Apparently a click cannot start on a child element that is removed during the action in Webkit.