Fixed #6796 #257
Merged
Fixed #6796 #257
+18
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed to buttonsets. Fixed #6796. jQueryui - buttonset on rtl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Button: Added rtl detection so corner classes would properly be applied to buttonsets. Fixed #6796. jQueryui - buttonset on rtl
Added
rtldetection to decide which corner class to apply to the first and last items.Added a unit test (Named "buttonset (rtl)") to verify the correct classes were being set.
Demo of fix: http://jsbin.com/arubu5/5
Note: It appears the background still bleeds through in IE9, though the corners are correct. I suspect this is an IE9 rtl bug. However, the background bled through before in IE9 before this fix was in place, and when rtl was set.