Skip to content

Button: Fixed 5254: Input, button and anchor buttons aren't consistent in IE7 #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
davidmurdoch wants to merge 3 commits into from
Closed

Button: Fixed 5254: Input, button and anchor buttons aren't consistent in IE7 #273

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
114b541
Fixed 5254: Input, button and anchor buttons aren't consistent in IE7…
May 13, 2011
755214e
The \0/ CSS hack needs a space before it to target only IE, otherwise…
May 13, 2011
8aeb0ab
Updating the IE9 hack to be less verbose - the media expression wasn'…
May 20, 2011
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Updating the IE9 hack to be less verbose - the media expression wasn'… 
…t actually needed. Also, I've appended "ie8+9" and "ie9" to the end of the winning-man hack, aka \0/, just to show exactly what that hack targets (don't want to confuse future devs TOO much).
  • Loading branch information
David Murdoch committed May 20, 2011
commit 8aeb0ab7a16a6bbbada0951f1f57bd1c04e02c23
7 changes: 3 additions & 4 deletions themes/base/jquery.ui.button.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ button.ui-button::-moz-focus-inner { border: 0; padding: 0; } /* reset extra pad
input.ui-button { padding: .43em .71em; } /* reset extra padding in Firefox */
}
a.ui-button-text-only .ui-button-text { padding: .46em 1.1em .56em !ie; } /* IE<8 needs some extra love to style anchors correctly */
input.ui-button { margin-right: .34em !ie; padding-top:.47em \0/; } /* IE6,7 need help with margins and IE8 doesnt treat our em padding correctly */
@media all and (min-width:0) {
input.ui-button { padding-top:.45em \0/; } /* IE9 is also a bit odd */
}
input.ui-button { margin-right: .34em !ie; padding-top:.47em\0/ie8+9; } /* IE6,7 need help with margins and IE8 doesnt treat our em padding correctly */

input.ui-button { padding-top:.45em \0/ie9; } /* IE9 is also a bit odd */