Position: Take margin into account when performing collisions. Fixes #5766 - position: collision should take margin into account #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#5766 - position: collision should take margin into account
|
Thanks. I tweaked the commit a bit for performance and landed it in 4b9d5d1 |
scottgonzalez
pushed a commit
to scottgonzalez/jquery-ui
that referenced
this pull request
Oct 17, 2011
Draggable: Use ._bind().
mikesherov
pushed a commit
to mikesherov/jquery-ui
that referenced
this pull request
Jan 14, 2013
abstract out createPlaceholder
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for http://dev.jqueryui.com/ticket/5766, making the collision functions for jquery.ui.position take into account the margin on the element being positioned. This will be really helpful if somebody wants to keep a "buffer" around a positioned element, or make sure the element's drop shadow (using -moz-box-shadow) doesn't go off the page and cause scrollbars.