Fixes: #7327 - Dialog box size and close animation bugs #300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 17, 2011 17:03
…eported in the ticket doesn't' seem to be a problem (maybe the padding and border from the ui theme was throwing the ticket-reporter off?)
|
Let me know that merge with "upstream master" there is going to mess things up. I'm not really sure what I did to put that there...but if it is a problem (I don't think it will be because it is up to date with you) let me know and I'll try to fix it. |
|
I actually can't seem to reproduce the bug in the first place using your test case... But either way, it kind of makes sense to not fire close code if |
| if ( self.options.hide ) { | ||
| self.uiDialog.hide( self.options.hide, function() { | ||
|
|
||
| if( self._isOpen ) { |
There was a problem hiding this comment.
spacing: if ( self._isOpen ) {
Please invert this so that it becomes:
if ( !self._isOpen ) {
return self;
}
|
Thanks, landed in c7eae7b. I moved the check to the very top of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This actually only fixes the close animation bug. I couldn't reproduce the dialog size issue stated in the ticket. I'm thinking the reporter may have been thrown off by the padding and border added by the ui theme.
The fix is pretty simply though: don't close a dialog that has already been closed.
Ticket 7327: http://bugs.jqueryui.com/ticket/7327