Skip to content

Resizable: Check if resizable is in a scrollable container and if so, add the scroll offsets when repositioning. Fixed #3815 - Resizable absolutely positioned element inside scrollable element is repositioned when resized #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kborchers wants to merge 1 commit into from
Closed

Resizable: Check if resizable is in a scrollable container and if so, add the scroll offsets when repositioning. Fixed #3815 - Resizable absolutely positioned element inside scrollable element is repositioned when resized #301

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 25 additions & 2 deletions ui/jquery.ui.resizable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@
* jquery.ui.widget.js
*/
(function( $, undefined ) {

var useOffset = false;

$.widget("ui.resizable", $.ui.mouse, {
widgetEventPrefix: "resize",
Expand Down Expand Up @@ -258,6 +260,24 @@ $.widget("ui.resizable", $.ui.mouse, {
if (o.containment) {
curleft += $(o.containment).scrollLeft() || 0;
curtop += $(o.containment).scrollTop() || 0;
} else {
//If containment is not set but resizable is in a scrollable container, recalculate position or use offset (see ticket #3815)
var lastLeft = lastTop = parentLeft = parentTop = 0;
el.parents( ":not(body, html)" ).each( function() {
if ( $.ui.hasScroll( this ) ) {
if( this === el.parent()[0] ) {
curleft += $( this ).scrollLeft() || 0;
curtop += $( this ).scrollTop() || 0;
useOffset = false;
return false;
} else {
curleft = el.offset().left;
curtop = el.offset().top;
useOffset = true;
return false;
}
}
});
}

//Store needed variables
Expand Down Expand Up @@ -301,9 +321,12 @@ $.widget("ui.resizable", $.ui.mouse, {
// plugins callbacks need to be called first
this._propagate("resize", event);

//If the resizable is in a scrollable container that is above its parent, use offset to position (see #3815)
el[ useOffset ? "offset" : "css" ]({
top: this.position.top + "px", left: this.position.left + "px"
});
el.css({
top: this.position.top + "px", left: this.position.left + "px",
width: this.size.width + "px", height: this.size.height + "px"
width: this.size.width + "px", height: this.size.height + "px"
});

if (!this._helper && this._proportionallyResizeElements.length)
Expand Down