Dialog: Add the possibility to set dialog("option", "zIndex", 3999) #313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…x", 3999 );', as noted in the docs on http://jqueryui.com/demos/dialog/ .
| @@ -595,6 +595,22 @@ $.widget("ui.dialog", { | |||
| $( ".ui-dialog-title", self.uiDialogTitlebar ) | |||
| .html( "" + ( value || " " ) ); | |||
| break; | |||
| case "zIndex": | |||
| if ( value > $.ui.dialog.maxZ ) { | |||
There was a problem hiding this comment.
I think this maxZ should only be set when the dialog is currently displayed
|
Okay, I can easily fix that of course. Can you merge this update when I do? Edit: alright, done and rebased; is it okay like this? |
…x", 3999 );', as noted in the docs on http://jqueryui.com/demos/dialog/ .
Conflicts: ui/jquery.ui.dialog.js
…x", 3999 );', as noted in the docs on http://jqueryui.com/demos/dialog/ .
Conflicts: tests/unit/dialog/dialog_options.js ui/jquery.ui.dialog.js
Merged
|
Don't need this anymore since 3829a37 landed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the possibility to use '$( ".selector" ).dialog( "option", "zIndex", 3999 );', as noted explicitly in the docs on http://jqueryui.com/demos/dialog/ :
Also added some tests. I'd say this ticket is applicable: http://bugs.jqueryui.com/ticket/4975 .