Skip to content

effects.scale: fix: calculate top / left by outerHeight / Width. #6096 #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 26, 2011

Conversation

tomykaira
Copy link
Contributor

effects.scale: fix: calculate top / left by outerHeight / Width. #6096 - effects.scale origin bottom bug.

The test is here.
https://gist.github.com/ee27fb7909acfd873c43

@gnarf
Copy link
Member

gnarf commented May 21, 2011

Fix seems to work, just missing Fixed #6096 in the commit message. CC @scottgonzalez

@tomykaira
Copy link
Contributor Author

Sorry, I am not used to git / github. Is that ok?

@gnarf
Copy link
Member

gnarf commented May 21, 2011

Its not really a git things, its a project thing: http://wiki.jqueryui.com/w/page/25941597/Commit-Message-Style-Guide

@tomykaira
Copy link
Contributor Author

Sorry, again. I misunderstood the rule. Is that ok?

I meant whether --amend is right way to fix this.

@gnarf
Copy link
Member

gnarf commented May 22, 2011

Yeah - you can amend... Thats fine... Fixed or Fixes would be preferred to Fix -- It triggers the automation in the bug tracker, which is why we like to have the proper format in the commit messages.

@tomykaira
Copy link
Contributor Author

Ohhhh, OMG. Very sorry.

I'll take care of it also in other commits.

@gnarf
Copy link
Member

gnarf commented May 22, 2011

@scottgonzalez -- this one looks pretty solid.

@scottgonzalez
Copy link
Member

Can you rebase this?

@tomykaira
Copy link
Contributor Author

Sure. I resolved a conflict.

scottgonzalez added a commit that referenced this pull request May 26, 2011
effects.scale: fix: calculate top / left by outerHeight / Width. #6096
@scottgonzalez scottgonzalez merged commit e89ae5f into jquery:master May 26, 2011
@scottgonzalez
Copy link
Member

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants