Effects.core: Storing size and setting in createWrapper for applied to all effects.

[tomykaira]

Effects.core: Storing size and setting in createWrapper for applied to all effects. Fixed #5245 - Relative width elements break when wrapped for effects.

This is discussed in #314 . Since this size problem is common among effects, I modified createWrapper and made it always store / set element size.

Testcase is included.

Acknowledgement: gnarf37.

[gnarf]

Since this is now done in the createWrapper - perhaps we should change the unit test to just call createWrapper and then check the width?

Change the module("effects.core") test( "createWrapper recalculates relative widths" )

And rather than .slide() just wrap up the relative width element and test its width before/after?

[gnarf]

As mentioned on the other pull - there are other effects that use createWrapper that we now need to make sure save/restore the width/height like you did for slide....

[tomykaira]

Sure. I moved the test to each.

Now all effects are tested with gnarf's code, and pass.

[gnarf]

And what about all the other effects, like drop that now do not save / restore the width and height?

[tomykaira]

The unit test says that exactly all effects (including drop, fade, fold and others not yet mentioned) works correctly.

I checked the behavior with eyes in https://gist.github.com/986073 .

I forgot testing height, so added it.

[gnarf]

Here -- Maybe this commit will better illustrate the problem I'm talking about...

All of those tests that are now failing will need to add "width", "height" to their saved props arrays...

Edited: Change my commit link, I had left a console.log in there accidentaly

[tomykaira]

Okey, the point was "restoring".

I added "width", "height" to all props, except "size".
In "size", I set restore always true, if mode is show/hide.

[gnarf]

Thanks! Landed in 2c81518