Datepicker: Check if typeof input === 'object' Fixed #6669 - Datepicker: _selectDate restores focus to non-object

[marcneuwirth]

Datepicker: Check if typeof input === 'object' Fixed #6669 - Datepicker: _selectDate restores focus to non-object

[gnarf]

I noticed there isn't already a test case for the issue on the trac - do you have one? @scottgonzalez was wondering if we even need this if statement at all. Thoughts?

[marcneuwirth]

I don't have a test case, just saw it in trac and fixed it while I was in datepicker for #7124 and #6669

[gnarf]

@marcneuwirth can you ammend this commit and just remove the if altogether... if the input is empty, .focus() won't do anything anyway since it .each's the collection

[marcneuwirth]

Hmm if i remove the if it will be:

this._lastInput = inst.input[0];
this._lastInput = null;

I'm guessing that second statement should be removed as well?

[gnarf]

No, the .focus() should stay inbetween those two lines... Is _lastInput used in the focus event by chance?

[gnarf]

The only thing missing right now is the test case... Got one yet? @scottgonzalez Do we know enough about this to just pull it?

[scottgonzalez]

I think we're fine to just land it after manual testing.

[gnarf]

Thanks, landed in 5f0a2f0