Droppable: Check if scrolling while dragging and recalculate droppable positions. Fixes #5003 - Scroll on Droppable Demo Breaks Demo #342
Conversation
…e positions. Fixes #5003 - Scroll on Droppable Demo Breaks Demo
ui/jquery.ui.droppable.js
Outdated
There was a problem hiding this comment.
Don't wrap this.element, it's already a jQuery object. Don't use .each() just to bind events, everything does implicit iteration.
ui/jquery.ui.droppable.js
Outdated
There was a problem hiding this comment.
This won't work, you need to use this.scrolling directly.
There was a problem hiding this comment.
Hmmm, it did seem to work in my tests in Chrome, FF, IE9 and IE6 but it also works using this.scrolling directly as well so I changed it.
|
Ok, so I feel kinda bad for not noticing this before, but... We'll need to bind on dragstart and unbind on dragstop, otherwise we won't be able to properly clean up the event handlers. This will require using a named function so we can unbind properly. |
|
No problem. If I would have gotten it right the first time it wouldn't have been an issue. ;-) Let me know how that commit looks. |
|
Drag methods don't exist on droppable. The methods are never called. |
|
Sorry about that, I just noticed that my test was broken and was working no matter what I changed. I will rework this. |
Droppable: Check if scrolling while dragging and recalculate droppable positions. Fixes #5003 - Scroll on Droppable Demo Breaks Demo