Datepicker: Calculate the max number of rows necessary when displaying months. Fixes #7043 - Datepicker: Using multiple months always renders 6 rows of dates even if only 5 are needed #353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g months. Fixes #7043 - Datepicker: Using multiple months always renders 6 rows of dates even if only 5 are needed
|
@scottgonzalez Here is my solution to this. I removed the numMonths check when closing the datepicker html and it appears to work for single and multi month datepickers in all browsers |
| @@ -1547,8 +1553,7 @@ $.extend(Datepicker.prototype, { | |||
| drawMonth = 0; | |||
| drawYear++; | |||
| } | |||
| calender += '</tbody></table>' + (isMultiMonth ? '</div>' + | |||
| ((numMonths[0] > 0 && col == numMonths[1]-1) ? '<div class="ui-datepicker-row-break"></div>' : '') : ''); | |||
| calender += '</tbody></table>' + (isMultiMonth ? '</div>' : ''); | |||
There was a problem hiding this comment.
Seems this diff would lose the ui-datepicker-row-break feature....
…ti-row datepicker.
…de font-size coming from ui-widget which caused the height to be too tall in IE
scottgonzalez
added a commit
that referenced
this pull request
Jun 16, 2011
Datepicker: Calculate the max number of rows necessary when displaying months. Fixes #7043 - Datepicker: Using multiple months always renders 6 rows of dates even if only 5 are needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Datepicker: Calculate the max number of rows necessary when displaying months. Fixes #7043 - Datepicker: Using multiple months always renders 6 rows of dates even if only 5 are needed