http://bugs.jqueryui.com/ticket/7467#362
Closed
JCall-Engineer wants to merge 1 commit intojquery:masterfrom
JCall-Engineer:master
Closed
http://bugs.jqueryui.com/ticket/7467#362JCall-Engineer wants to merge 1 commit intojquery:masterfrom JCall-Engineer:master
JCall-Engineer wants to merge 1 commit intojquery:masterfrom
JCall-Engineer:master
Conversation
…xed #7467 - Datepicker icon should have more descriptive alt text
Member
|
I'm a little torn about changing the default option value here. Although "Pick Date" makes more sense than "..." for a default in my opinion, don't forget that this is also the plain "button text" when you don't use an image too: http://cl.ly/3V2u360m1X0L1q3s280s Also - This broke a unit test, here is a commit to fix it: gnarf@21b9ba7 I'm waiting on another opinion here, @scottgonzalez @rdworth @jzaefferer |
Member
|
This also causes almost every locale to default to an invalid value. |
Author
|
:S And I thought i was picking a simple change/enhancement |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Datepicker: changed default button text to 'Pick Date' on line 69. Fixed #7467 - Datepicker icon should have more descriptive alt text