Button: Set ui-state-active class accordingly to the checkbox state. Fixe#402
Closed
mmartin wants to merge 4 commits intojquery:masterfrom
mmartin:patch-1
Closed
Button: Set ui-state-active class accordingly to the checkbox state. Fixe#402mmartin wants to merge 4 commits intojquery:masterfrom mmartin:patch-1
mmartin wants to merge 4 commits intojquery:masterfrom
mmartin:patch-1
Conversation
…Fixed #5518 - ui.button double clicking issue
Member
|
This is actually causing it to consistently fail for me. |
Author
|
It should be fixed now (sorry about commits' descriptions). I have improved the test case (it pulls the fixed code from github now): http://jsbin.com/axube5/16/ |
Member
|
@mmartin, could you add unit tests supporting your change here, and rebase this pull against master so it's in a state to land? Thanks again! |
Member
|
Thanks for contributing! We ended up landed a different fix for this. Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Button: Set ui-state-active class accordingly to the checkbox state. Fixed #5518 - ui.button double clicking issue