Allow a tabs() option to specify the container which will hold panels #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ption to specify the container which will hold panels
|
We're going to remove the add method and add a refresh method. The idea is that you will add the tab to the list and then place the panel wherever you want to. Since this will make this change irrelevant, we're not going to land it. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a need for a panelsContainer option in tabs(). I opened ticket #6654 for this:
When allowing tabs() to auto-create panels, one has no control over where that panel will be created.
For our layout we need finer control on where auto-generated panels go.
Add an option "panelContainer" that specifies a selector or DOM element where auto-created panels will be placed.