ui-spinner decimal value rounding fix #428
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. Added three tests to confirm this behavior, "decimalStep", "decimalValueIntegerStep", and "integerValueDecimalStep"
|
Thanks, landed a cleaner implementation in 257021b. |
|
The new tests that I included on this pull request still fail on the latest version in master. 25f2113 |
|
Those tests are no longer valid as they use the value option. Do they still fail if you update the tests? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified ui-spinner's _spin method to round new values to existing decimal lengths. Added three tests to confirm this behavior, "decimalStep", "decimalValueIntegerStep", and "integerValueDecimalStep". Creating a pull request per Jörn Zaefferer.