Autocomplete: Bug #7639 - Added an option for not activating the autocomplete menu with arrow keys #445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…u with the arrow keys. Fixed #7639 - Key up/key down in textarea's should optionally not toggle auto-complete.
|
Any progress? |
|
After some discussion, we've decided that it's probably better to automatically determine whether the arrow keys should activate the menu. If the element is a textarea or is contenteditable, then the arrow keys should not activate the menu. Can you update the pull request to detect this and remove the option? Thanks. |
|
I was going to try and take a look this weekend, but I completely forgot. I'll try and take a look this week, or next weekend. |
…rrows don't activate menu in textarea/contenteditable. Fixed #7639 - Key up/key down in textarea's should optionally not toggle auto-complete.
|
OK I've updated the pull request so that text area's and contenteditable elements no longer activate the menu. |
|
Thanks, landed in 06f6fa8 with a performance update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Autocomplete: Added an option for not activating the autocomplete menu with the arrow keys. Fixed #7639 - Key up/key down in textarea's should optionally not toggle auto-complete.
This bug should be fixed, and it includes appropriate unit tests as well.