Fixed #7692 Dialog, Fixed #5979 button #449
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the nonContentHeight. Fixed #7692 - dialog: dialog height bug is incorrect when .ui-dialog padding set
…age elements inside the button. Fixed #5979 - Radio Button with image inside doesn't work when image is clicked.
|
Could you send a separate request for the dialog fix, along with a unit test for that? The button fix looks sketchy, but at least that should go in a separate PR, so that we can land the dialog fix. |
|
Not having used Git before i've been struggling with it. Hopefully the new pull request i've submitted is what you are looking for. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dialog: modified the dialog._size()to use outerHeight in calculating the nonContentHeight. Fixed #7692 - dialog: dialog height bug is incorrect when .ui-dialog padding set
Button: modified the _create function to add a click event to any image elements inside the button. Fixed #5979 - Radio Button with image inside doesn't work when image is clicked.