Position: Added a check for fraction support in element positions based on @inukshuk's original method #460
Conversation
…ed on @inukshuk's original method
|
In which browser/jquery combo did this fail? |
|
I just fetched and merged upstream/1-8-stable into my branch and ran the tests in FF6.
Same results using version 1.4.4. and, I assume, for all versions prior to 1.6. |
|
@jzaefferer Before this change, the bug #5280 test failed in IE9 and FF6 (probably older IE's as well). After the change all position tests pass in all browsers with 1.6.2. Unfortunately, this change causes the fractions test to fail in FF6 in older version of jQuery because the browser supports fractions but jQuery does not so the test expects fractions but the values are rounded. I'm not sure what we can do about that since it's old versions of jQuery rounding, not UI. Thoughts? |
|
I'm not seeing a test failure in FF6 without the patch, both on Windows XP and OSX. What am I missing? |
|
Scratch that, it fails with jQuery 1.5.2, but not 1.6.x. I lost track of where we need to support this, and what failures matter or not, e.g. 1.9 doesn't really support anything older then 1.6, while 1-8-stable does (I guess). @scottgonzalez, could you take a look and land it? |
|
Just tried merging this into 1-8-stable, that fails pretty badly. @kborchers could you redo this against 1-8-stable (instead of master)? |
|
OK, so merging into 1-8-stable makes sense but that still doesn't address the issue of Firefox and old version of jQuery. The fraction and 5280 tests are going to fail because the browsers supports fraction but jQuery does not. This causes the test results to not match. Should I merge this with or without those tests and if with, do we just accept that they fail in FF? |
Position: Added a check for fraction support in element positions based on @inukshuk's original method