Skip to content

Draggable: Scale click registration point for heterogeneous-sized clone #522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
duncanbeevers wants to merge 1 commit into from
Closed

Draggable: Scale click registration point for heterogeneous-sized clone #522

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions ui/jquery.ui.draggable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,9 @@ $.widget("ui.draggable", $.ui.mouse, {
//Create and append the visible helper
this.helper = this._createHelper(event);

//Cache the element's size
this._cacheElementProportions();

//Cache the helper size
this._cacheHelperProportions();

Expand Down Expand Up @@ -351,6 +354,13 @@ $.widget("ui.draggable", $.ui.mouse, {
};
},

_cacheElementProportions: function() {
this.elementProportions = {
width: this.element.outerWidth(),
height: this.element.outerHeight()
};
},

_cacheHelperProportions: function() {
this.helperProportions = {
width: this.helper.outerWidth(),
Expand Down Expand Up @@ -418,6 +428,17 @@ $.widget("ui.draggable", $.ui.mouse, {
var pageX = event.pageX;
var pageY = event.pageY;

// Correct for cloned element dimension differences
if ( this.helper.options == 'clone' && !this.helperProportions.width && !this.helperProportions.height ) {
this._cacheHelperProportions();
var xAspect = this.helperProportions.width / this.elementProportions.width,
yAspect = this.helperProportions.height / this.elementProportions.height;
if ( xAspect && yAspect ) {
this.offset.click.left *= xAspect;
this.offset.click.top *= yAspect;
}
}

/*
* - Position constraining -
* Constrain the position to a mix of grid, containment.
Expand Down