Menubar: Allow structures other than just UL/LI and combine the _next, _prev, _right and _left into _move #541
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…od called _move and then created next and previous public methods that call _move. Very similar to how Menu handles keyboard interaction.
| @@ -53,7 +57,8 @@ $.widget( "ui.menubar", { | |||
| // TODO what is this targetting? there's probably a better way to access it | |||
| $(event.target).prev().focus(); | |||
| that._trigger( "select", event, ui ); | |||
| } | |||
| }, | |||
| items: that.options.menuElement | |||
There was a problem hiding this comment.
There's a mismatch here - do we need to rename Menu's items option to menus or something?
There was a problem hiding this comment.
That would probably make more sense, I was just trying to stick with the items option that we use on other widgets but it probably isn't the best choice here.
|
Anyone else have input on this before I merge it? |
|
@jzaefferer, @scottgonzalez, @gnarf, @fnagel Anyone else have comments? If not, I would like to merge this today. |
|
@fnagel I just realized this doesn't effect you, sorry. Working on menu and menubar at the same time. |
kborchers
added a commit
that referenced
this pull request
Dec 7, 2011
Menubar: Allow structures other than just UL/LI and combine the _next, _prev, _right and _left into _move
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Menubar: Allow structures other than just UL/LI and combine the _next, _prev, _right and _left into _move