Dialog: When destroy is called place the element back in original DOM position. Fixed #4980 - Dialog: Destroy should place element back in original DOM position #553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -78,6 +78,8 @@ $.widget("ui.dialog", { | |||
| if ( typeof this.originalTitle !== "string" ) { | |||
| this.originalTitle = ""; | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
No spaces on blank lines.
|
Can you add a test for this? |
|
I will add a test and make the changes |
|
Thanks. |
|
Commit changed, I guess thats ok. |
| @@ -168,7 +171,7 @@ $.widget("ui.dialog", { | |||
| }, | |||
|
|
|||
| _destroy: function() { | |||
| var self = this; | |||
| var self = this, oldPosition = this.oldPosition, next = null; | |||
There was a problem hiding this comment.
separate line for each var
|
Commit changed |
| @@ -183,6 +188,13 @@ $.widget("ui.dialog", { | |||
| if ( self.originalTitle ) { | |||
| self.element.attr( "title", self.originalTitle ); | |||
| } | |||
|
|
|||
| next = oldPosition.parent.children().eq( oldPosition.index ); | |||
| if( next.length ) { | |||
|
Thanks Alberto. Just two minor changes and we're good to go. Thanks for making all the changes so quickly and providing a better solution than what we had planned. |
… position. Fixed #4980 - Dialog: Destroy should place element back in original DOM position
|
Thanks Scott, it was a pleasure to contribute to improving the jQuery UI |
scottgonzalez
added a commit
that referenced
this pull request
Dec 15, 2011
Dialog: When destroy is called place the element back in original DOM position. Fixed #4980 - Dialog: Destroy should place element back in original DOM position
|
Merged! Thanks again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dialog: When destroy is called place the element back in original DOM position. Fixed #4980 - Dialog: Destroy should place element back in original DOM position