Skip to content

Fixes: #4857 - Nested lists don't work properly with sortable. #555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Dec 20, 2011

Fixes: #4857 - Nested lists don't work properly with sortable.

This commit, as tiny as it may be, makes nested-sortables actually usable.

Martin Hoch hoch@fidion.de added 2 commits December 20, 2011 11:49
Fixes: #4857 - Nested lists don't work properly with sortable.
@ghost
Copy link
Author

ghost commented Jan 2, 2012

I also Fixed #5159. Am I really the only one who uses nested-sortables? :-)

@johnny
Copy link

johnny commented Feb 3, 2012

+1 for this pull request

@loopforever
Copy link

+1 for this request as well. Actually makes nested sortables work.

@burkeholland
Copy link

SRSLY? Maintenance release 1.8.18 is out and I still don't see this fix. Did I miss it?

@jeffchao
Copy link

+1 for pull request. Nested sortables problem is very real. This helps.

@adamstrawson
Copy link

+1 for pull this pull request.

@hetsch
Copy link

hetsch commented Mar 26, 2012

+1 for pull request. Helps a lot!

@burkeholland
Copy link

Any update on this? I know many of us are working with a modified version of the library to support this. We would love to see it be official so that others looking for the functionality don't have to find it the hard way.

@real-didi
Copy link

+1 for pull request. It solved the problem and helped a lot.
To make it fully work for me:

  • a sortable for each nested list
  • removed option 'toleranceElement' since no need in it with this fix

@joeellis
Copy link

Also wondering on the status of this PR

@me
Copy link

me commented Apr 5, 2012

Wow, this actually works! Nested lists are usable at last! Thanks. +1

@codeincontext
Copy link

+1 Wish I discovered this earlier

@Jellyfrog
Copy link

+1

1 similar comment
@takempf
Copy link

takempf commented Aug 15, 2012

+1

@Carenthir
Copy link

+1 , this is brilliant.
Thanks Martin, this is weird the UI guys haven't merged the fix yet.

@terracatta
Copy link

+1
Can we get this merged in please? Or a least a reason why a merge isn't possible?

@gnarf
Copy link
Member

gnarf commented Aug 22, 2012

Sorry this one has sat around for so long, there have obviously been some people testing and supporting it. This widget still hasn't been re-written yet which is why we have taken our time landing any updates to it.

What would definitely help is if you could provide a unit test for this functionality, so that we can ensure we continue to support this after the rewrite, and won't regress.

We plan on trying to land this before the 1.9 Release.

@scottgonzalez
Copy link
Member

Thanks, this has finally landed in master: 2b899cc and b9ef00f.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.