Browser sniffing for http://dev.jquery.com/ticket/4014#575
Closed
chrissmith-examtime wants to merge 1 commit intojquery:masterfrom
Closed
Browser sniffing for http://dev.jquery.com/ticket/4014#575chrissmith-examtime wants to merge 1 commit intojquery:masterfrom
chrissmith-examtime wants to merge 1 commit intojquery:masterfrom
Conversation
Member
|
You must not understand the purpose behind feature detection. This will never land. If you're having problems, file a ticket. |
Author
|
Ok, raised a bug: http://bugs.jqueryui.com/ticket/8026 Out of curiosity, seeing that IE9 is only browser this seems to effect and the code causing the issue is only there to support IE6... what is the best way to go about this? |
Member
|
Figure out the actual problem and fix it. It doesn't matter what browsers it affects, we won't accept code that uses $.browser. |
Member
|
FWIW, here's the diff for the old core ticket you referenced. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran into an issue with jquery-ui breaking sticky footers in IE9, tracked it down to the code that runs on document ready in jquery.ui.core.js, it creates an empty div at the end of the page and deletes it, apparently to solve an old IE6 layout bug: http://dev.jquery.com/ticket/4014
In IE9 this leaves white space after my sticky footer, quick fix was to add browser sniffing around this section to only run for old versions of IE.