Display a string inside .ui-progressbar-value #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We discussed this as a team and have decided that we don't want to add this to the core of the progressbar plugin. There are too many different ways that informations can be presented about a progressbar: inside, below, to the side, etc. However, this would be a useful extension. If you're not sure how to extend a plugin without modifying the original code, check out github.com/scottgonzalez/jquery-ui-extensions for some examples. |
|
OK, thanks :) I'll reimplement it as an extension then. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I saw this this ticket: http://dev.jqueryui.com/ticket/5462 and decided to implement it as I find the idea useful for a project of mine.
Is my code good enough for jquery-ui? :)