Draggable: Don't run stop methods for elements that have been removed. ...#639
Closed
tjvantoll wants to merge 1 commit intojquery:masterfrom
Closed
Draggable: Don't run stop methods for elements that have been removed. ...#639tjvantoll wants to merge 1 commit intojquery:masterfrom
tjvantoll wants to merge 1 commit intojquery:masterfrom
Conversation
Member
|
Thanks, landed in 27d1023. |
Member
There was a problem hiding this comment.
There's nowhere else to go. The only extra overhead is checking if element.parentNode exists.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...Fixed #8269 (http://bugs.jqueryui.com/ticket/8269)
I tried to come up with a way to unit test this but I couldn't get anything to work (it's dependent on a draggable being dropped on a droppable). Anyways, this fixes the test case in the bug and doesn't appear to have any adverse effects on the demos.