When options.axis is "x" or "y", allow drag to rearrange placeholder element even when outside of the container element.#640
Closed
MoonScript wants to merge 1 commit intojquery:masterfrom
MoonScript:master
Closed
When options.axis is "x" or "y", allow drag to rearrange placeholder element even when outside of the container element.#640MoonScript wants to merge 1 commit intojquery:masterfrom MoonScript:master
MoonScript wants to merge 1 commit intojquery:masterfrom
MoonScript:master
Conversation
…holder doesn't move when dragging outside of container element
Member
|
Thanks, landed in b8b0c52. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You can see this fix in-action here:
http://jsfiddle.net/MoonScript/vLyfU/7/show/
(Full Fiddle source: http://jsfiddle.net/MoonScript/vLyfU/7/)
Once you grab an item and start dragging up and down, move your mouse to the left as you drag, and you'll see that the yellow placeholder element will move up and down along with your mouse.
You can see how it currently works to compare:
http://jsfiddle.net/MoonScript/vLyfU/show/