Datepicker: Fixed #8420 - Datepicker: calculateWeek doesn't take firstDay setting into account#693
Closed
ghiculescu wants to merge 5 commits intojquery:masterfrom
Closed
Datepicker: Fixed #8420 - Datepicker: calculateWeek doesn't take firstDay setting into account#693ghiculescu wants to merge 5 commits intojquery:masterfrom
ghiculescu wants to merge 5 commits intojquery:masterfrom
Conversation
…423 - Datepicker: displaying multiple months shows an extra row of dates on months subsequent to a "long" month
…Fixes #8423 - Datepicker: displaying multiple months shows an extra row of dates on months subsequent to a "long" month" This reverts commit c843b45.
…423 - Datepicker: displaying multiple months shows an extra row of dates on months subsequent to a "long" month
…ixes #8420: Datepicker: calculateWeek doesn't take firstDay setting into account
Member
|
@ghiculescu, thanks for contributing! Can you write unit tests for this pull request supporting your change? |
Member
|
Do you have examples of other calendars that do this? |
Member
|
Closing due to inactivity. Please comment on the associated ticket if you'd like to continue this discussion. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ghiculescu@7741b03 is the relevant commit. The others are just fiddling around (and then reverting that fiddling) with the rows to show in the date picker, for #8423.
The datepicker should show months like http://i.imgur.com/Y1xGR.png - in this case with firstDay: 0.