Datepicker: Added 'html >' to body selector. Fixed #8464 - Datepicker does not properly scope the body selector.#706
Merged
Conversation
Member
|
That should just be |
…epicker does not properly scope the body selector.
Contributor
Author
|
Updated. |
Member
|
Thanks, landed. |
|
This appears to have regressed at some point. Line 304 of jquery.ui.datepicker in version 1.10.3 now has "$("body").append(this._dialogInput);", and this again has the above bug with multiple body elements breaking the datepicker. |
Member
|
Why are you generating pages with multiple bodies anyway? |
Member
|
Nevermind, I looked back at the original ticket. |
Member
|
Considering that even before this regressed, there were still multiple uses of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request simply makes the body selector more explicit. This avoids an issue with multiple body elements existing which causes datepicker to break.