Button: Fixed: #8203 – button: 'text' is a confusing name for the option#712
Closed
WebsiteDeveloper wants to merge 1 commit into
Closed
Button: Fixed: #8203 – button: 'text' is a confusing name for the option#712WebsiteDeveloper wants to merge 1 commit into
WebsiteDeveloper wants to merge 1 commit into
Conversation
Button: Changed variable text to showLabel Fixed: #8203 – button: 'text' is a confusing name for the option
Member
|
@WebsiteDeveloper, thanks for submitting this pull request, but it's not going to land as is without unit tests for the behavior and not without a back compat way to migrate from the old option to the new option. I'm going to close this pull until the 1.11 line begins development, at which time you can submit a new pull request that addresses the issues I've raised! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Button: Changed variable text to showLabel Fixed: #8203 – button: 'text' is a confusing name for the option