Skip to content

Tabs/Dialog: Modified to use event.preventDefault() instead of return false for some event handlers #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MaxPower15 wants to merge 3 commits into from
Closed

Tabs/Dialog: Modified to use event.preventDefault() instead of return false for some event handlers #73

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3d81302
Tabs: Modified anchor bindings to use event.preventDefault() instead …
MaxPower15 Dec 16, 2010
de8512f
Dialog: Modified close button binding to use event.preventDefault() i…
MaxPower15 Dec 16, 2010
94e9a6c
Tabs: adding semicolon after return, fixing styling around function d…
MaxPower15 Dec 17, 2010
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ui/jquery.ui.dialog.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,8 +152,8 @@ $.widget("ui.dialog", {
uiDialogTitlebarClose.removeClass('ui-state-focus');
})
.click(function(event) {
event.preventDefault();
self.close(event);
return false;
})
.appendTo(uiDialogTitlebar),

Expand Down
13 changes: 7 additions & 6 deletions ui/jquery.ui.tabs.js
100644 → 100755
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,7 +333,8 @@ $.widget( "ui.tabs", {
};

// attach tab event handler, unbind to avoid duplicates from former tabifying...
this.anchors.bind( o.event + ".tabs", function() {
this.anchors.bind( o.event + ".tabs", function( event ) {
event.preventDefault();
var el = this,
$li = $(el).closest( "li" ),
$hide = self.panels.filter( ":not(.ui-tabs-hide)" ),
Expand All @@ -349,7 +350,7 @@ $.widget( "ui.tabs", {
self.panels.filter( ":animated" ).length ||
self._trigger( "select", null, self._ui( this, $show[ 0 ] ) ) === false ) {
this.blur();
return false;
return;
}

o.selected = self.anchors.index( this );
Expand All @@ -370,7 +371,7 @@ $.widget( "ui.tabs", {
}).dequeue( "tabs" );

this.blur();
return false;
return;
} else if ( !$hide.length ) {
if ( o.cookie ) {
self._cookie( o.selected, o.cookie );
Expand All @@ -384,7 +385,7 @@ $.widget( "ui.tabs", {
self.load( self.anchors.index( this ) );

this.blur();
return false;
return;
}
}

Expand Down Expand Up @@ -418,8 +419,8 @@ $.widget( "ui.tabs", {
});

// disable click in any case
this.anchors.bind( "click.tabs", function(){
return false;
this.anchors.bind( "click.tabs", function( event ){
event.preventDefault();
});
},

Expand Down