Button: added replace on radio name to escape quotes. Fixed #7505 - Butt...

[DaleKocian]

...on: Buttonset not applied to radio group with quotation/apostrophe in name

[jzaefferer]

We need a more general escaping that isn't specific to single characters. Probably overlaps with what tabs is already doing:

jquery-ui/ui/jquery.ui.tabs.js

Line 296 in 94221c4

_sanitizeSelector: function( hash ) {

[jzaefferer]

Duplicate of #401 :sadpanda:

[jzaefferer]

Kind of. Leaving this open for now.

[gnarf]

I like this better than #401 since it only escapes the ' - Gonna close that old one

[mikesherov]

@gnarf37, @jzaefferer what's the status of this pull request? And it also needs tests if it's going to land, right?

[jzaefferer]

@DaleKocian could you add a unit test for this? Also, the replace call should happen inside the if ( name ) so that it doesn't throw up when there is no name property.

[mikesherov]

@jzaefferer, besides a unit test, we'd also want to generalize the solution using

jquery-ui/ui/jquery.ui.tabs.js

Line 296 in 94221c4

_sanitizeSelector: function( hash ) {

, right?

[scottgonzalez]

I'm fine moving that method to core if it makes sense.

[jzaefferer]

No we don't, according to @gnarf37 commenting here: #401 (comment)

[mikesherov]

Ok, thanks @jzaefferer

[mikesherov]

Landed something similar in cc7df71