Skip to content

resizable: fixed #5651 - destroy method bug on some bordered elements#765

Closed
kenjiyamamoto wants to merge 1 commit intojquery:masterfrom
kenjiyamamoto:bug-5651
Closed

resizable: fixed #5651 - destroy method bug on some bordered elements#765
kenjiyamamoto wants to merge 1 commit intojquery:masterfrom
kenjiyamamoto:bug-5651

Conversation

@kenjiyamamoto
Copy link

No description provided.

@scottgonzalez
Copy link
Member

Is there a reason not to just remove these two lines?

@mikesherov
Copy link
Member

@scottgonzalez, technically, this would break with an alternate box-sizing. Should just be updated to .css('width') and .css('height') if anything.

@mikesherov
Copy link
Member

Hi @kenjiyamamoto, thanks again for contributing this patch. We recently re-enabled the test suite for resizable. In order for us to land this patch, we'd need a few tests added to the test suite proving this doesn't break existing functionality and also that it fixes the bug as described. Can you add some tests here please?

@mikesherov
Copy link
Member

I'm going to go ahead and close this pull request, as it's not a high priority to fix at the moment, and we'd need an active from response from @kenjiyamamoto to move forward, which have not gotten. @kenjiyamamoto, if at any point you'd like to continue pursuing this pull request, please submit a new one. Thanks again for the work here!

@mikesherov mikesherov closed this Nov 30, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants