Effect: check if option parameter is an object. Fixed #8670 - null reference when using effects

[maciejmrozinski]

No description provided.

[mikesherov]

Thanks for contributing! Can you add a unit test for this as well?

[maciejmrozinski]

I've never done that before:/ Can You guide me, tell me where to start, how unit test should looks like? What should i check within it? Thanks for any help.

[gnarf]

Thanks for forcing my hand on this one, I was planning on the == null check anyway.

[gnarf]

P.S. my commit also included a unit test so you can check out how you go about writing one of those.

[maciejmrozinski]

Thanks for this unit test. I will learn to write those for better contributing :) Please correct me if i am wrong. Is options == null the same as options == undefined?

[gnarf]

options == null will only be true for null and undefined - It is the only case we use == inside jQuery code for exactly this reason.