Dev: Standardized the draggable test suite. Fixed #8748 - Dev: Get draggable test suite to pass#797
Closed
mikesherov wants to merge 1 commit intojquery:masterfrom
Closed
Dev: Standardized the draggable test suite. Fixed #8748 - Dev: Get draggable test suite to pass#797mikesherov wants to merge 1 commit intojquery:masterfrom
mikesherov wants to merge 1 commit intojquery:masterfrom
Conversation
tests/unit/draggable/draggable.html
Outdated
Member
|
I only really glanced at the individual test files, but I looked through the other files and I think this is fine to land after my two questions are addressed. I'm fine with addressing the stuff @gnarf37 pointed out afterward if you want. You can also uncomment jquery-ui/build/tasks/testswarm.js Line 18 in a688e7c |
…aggable test suite to pass
Member
Author
|
@scottgonzalez updated! |
Member
|
Thanks, landed in f0daa22. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed with @scottgonzalez, this pull gets the draggable test suite to a base state of sanity for future contribution by others!