Closed
Conversation
Member
|
Thanks. At first glance this looks good. I don't have much time right now, but I'll do a full review early next week. In the meantime, could you please sign our CLA? |
Contributor
Author
|
Signed! |
Member
|
Thanks, I landed the resizable fix in 0bff32a. I'd like the test for the draggable fix to be inside the draggable test suite. I also left a comment on the commit about the implementation. Would you mind sending another PR for the draggable change? |
Contributor
Author
|
On it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contains tests and code to handle complex markup in resizable handles.
Second attempt at a pull request. I made a branching mistake last time...
This time it contains http://bugs.jqueryui.com/ticket/8756 and http://bugs.jqueryui.com/ticket/8757