Skip to content

Added "icons" option for UI Dialog buttons #822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Added "icons" option for UI Dialog buttons #822

wants to merge 3 commits into from

Conversation

alexeevdv
Copy link

It allows you to add custom icons for dialog buttons.
You can see example here: http://jsfiddle.net/alexeevdv/g5pYa/

@jzaefferer
Copy link
Member

This overlaps with #423, which also forwards a "showText" property. I think what we really need is a way to customize all button options, especially since button is becoming a required dependency for dialog (when using the buttons option).

@alexeevdv
Copy link
Author

i added a list of allowed button options which will be trimmed from common options. if text is not specified or false it will not shown. You can see it on example page: http://jsfiddle.net/alexeevdv/g5pYa/

@scottgonzalez
Copy link
Member

The problem with having a pass-thru to the buttons API is that we currently have a pass-thru to .attr() and they don't mix well. There was already a discussion about this in http://bugs.jqueryui.com/ticket/6830 and the best API seems to be showText and icons in addition to full support of .attr().

@jzaefferer
Copy link
Member

Buttons should always have text, so closing this in favour of #423. Which I'm probably not going to merge either, as it doesn't have tests and needs to be rebased on the dialog branch.

@jzaefferer jzaefferer closed this Nov 16, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants