Skip to content

Dialog: Restrict title to a single line. Fixes #7773 - Dialog: If titleb...#856

Merged
jzaefferer merged 1 commit intomasterfrom
dialog-7773
Dec 3, 2012
Merged

Dialog: Restrict title to a single line. Fixes #7773 - Dialog: If titleb...#856
jzaefferer merged 1 commit intomasterfrom
dialog-7773

Conversation

@jzaefferer
Copy link
Member

...ar changes height during resize, button pane positioning changes.

As discussed on the ticket and IRC. Tested this, using the modified complex-dialog visual test, in Chrome, Firefox and IE7. In IE7, the close button disappears below a certain size. The title handling itself works fine.

@tjvantoll
Copy link
Member

If we're going with the approach would it make sense to also give the .ui-dialog-title <span> a title attribute so the user can see the full title on hover? Currently it does not have one.

@scottgonzalez
Copy link
Member

I still think 90% is a better width. At 95% with normal size text, the ellipses can be right up against the close button even at 250px wide. I'm not sure what causes the close button to stop moving in IE7, but when you stop resizing, it does reappear in the correct place, so I think it's fine.

@scottgonzalez
Copy link
Member

@tjvantoll I've got mixed feeling about adding a title attribute. I wouldn't want it to show up when the text isn't truncated.

@jzaefferer
Copy link
Member Author

Updated to set the width at 90% and use a regular font-size in the complex-dialog visual test. I also agree with Scott on the title attribute - that would be only useful when the text is truncated, for 99% of dialogs it would be just irritating.

…lebar changes height during resize, button pane positioning changes.
@jzaefferer jzaefferer merged commit bdb0fbe into master Dec 3, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants