Slider: Fixed #8892 - Multiple Range Sliders Conflict with options.values#862
Closed
dominicbarnes wants to merge 1 commit intojquery:masterfrom
dominicbarnes:slider-8892-multiple_range_fix
Closed
Slider: Fixed #8892 - Multiple Range Sliders Conflict with options.values#862dominicbarnes wants to merge 1 commit intojquery:masterfrom dominicbarnes:slider-8892-multiple_range_fix
dominicbarnes wants to merge 1 commit intojquery:masterfrom
dominicbarnes:slider-8892-multiple_range_fix
Conversation
…- Multiple Sliders have Conflict with options.values
Member
|
Thanks Dominic, this fix looks good. Could you please sign our CLA? |
Contributor
Author
|
@scottgonzalez Just signed and submitted. :) |
Member
|
Thanks Dominic. I changed the email address on the commit to match the email address you used in the CLA. In the future, please either sign the CLA again with the other email address or change your git info to match the CLA. Landed in 209443d. Thanks again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trac Ticket
This commit/PR fixes the aforementioned bug, and adds unit tests to show that.
In a nutshell, the object reference (the
option.valuesarray) is shared between all the sliders initialized if you initialize more than 1 at a time. The solution here was to create a clone of that array during_create.