Build: Migrate to grunt 0.4. #867
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,6 +5,19 @@ module.exports = function( grunt ) { | |
| var path = require( "path" ), | ||
| fs = require( "fs" ); | ||
|
|
||
| function expandFiles( files ) { | ||
|
There was a problem hiding this comment. Why is this There was a problem hiding this comment. The other one is used directly, and only points at files. This one is used via tasks and gets folder wildcards as inputs. Folders have to be filtered out. I'm not sure what you mean with "expose it instead of redefining it". See also gruntjs/grunt#700 |
||
| return grunt.util._.pluck( grunt.file.expandMapping( files ), "src" ).filter(function(filepath) { | ||
| // restrict to files, exclude folders | ||
| try { | ||
| return fs.statSync( filepath[ 0 ] ).isFile(); | ||
| } catch(e) { | ||
| throw grunt.task.taskError(e.message, e); | ||
| } | ||
| }).map(function( values ) { | ||
| return values[ 0 ]; | ||
| }); | ||
| } | ||
|
|
||
| grunt.registerTask( "manifest", "Generate jquery.json manifest files", function() { | ||
| var pkg = grunt.config( "pkg" ), | ||
| base = { | ||
|
|
@@ -97,8 +110,8 @@ grunt.registerMultiTask( "copy", "Copy files to destination folder and replace @ | |
| grunt.file.copy( src, dest ); | ||
| } | ||
| } | ||
| var files = expandFiles( this.filesSrc ), | ||
| target = this.data.dest + "/", | ||
| strip = this.data.strip, | ||
| renameCount = 0, | ||
| fileName; | ||
|
|
@@ -121,28 +134,11 @@ grunt.registerMultiTask( "copy", "Copy files to destination folder and replace @ | |
|
|
||
|
|
||
| grunt.registerMultiTask( "zip", "Create a zip file for release", function() { | ||
| var done = this.async(), | ||
| dest = this.data.dest; | ||
| grunt.util.spawn({ | ||
| cmd: "zip", | ||
| args: [ "-r", dest, this.data.src ], | ||
| opts: { | ||
| cwd: 'dist' | ||
| } | ||
|
|
@@ -159,19 +155,19 @@ grunt.registerMultiTask( "zip", "Create a zip file for release", function() { | |
|
|
||
| grunt.registerMultiTask( "md5", "Create list of md5 hashes for CDN uploads", function() { | ||
| // remove dest file before creating it, to make sure itself is not included | ||
| if ( fs.existsSync( this.data.dest ) ) { | ||
| fs.unlinkSync( this.data.dest ); | ||
| } | ||
| var crypto = require( "crypto" ), | ||
| dir = this.filesSrc + "/", | ||
| hashes = []; | ||
| expandFiles( dir + "**/*" ).forEach(function( fileName ) { | ||
| var hash = crypto.createHash( "md5" ); | ||
| hash.update( grunt.file.read( fileName, "ascii" ) ); | ||
| hashes.push( fileName.replace( dir, "" ) + " " + hash.digest( "hex" ) ); | ||
| }); | ||
| grunt.file.write( this.data.dest, hashes.join( "\n" ) + "\n" ); | ||
| grunt.log.writeln( "Wrote " + this.data.dest + " with " + hashes.length + " hashes" ); | ||
| }); | ||
|
|
||
| grunt.registerTask( "generate_themes", function() { | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's with this? Does
grunt.file.expandFilesno longer exist? What does it not (or no longer) do thatgrunt.file.expandMapping(called fromexpandFiles) does do?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
expandFilesis gone andexpandMappingsreturns a map of src -> dest, not an array.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Crap, you're right. It was removed...