Ticket 5124 - Updating php scripts #88
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems that search.php in the autocomplete demo had the chance of throwing a NOTICE by accessing
$_GET['term']
without checkingisset()
orempty()
- also, rather than reimplementjson_encode()
I switched it to just use the PHP builtin.I don't see any other php scripts in the GIT that handle input variables, or have escaping issues, so, unless some are hiding on the docs page that I haven't seen, I think this ticket is resolved after this...