Dialog: modified _createOverlay to _appendTo instead of document.body. F...#894
Closed
djQuery wants to merge 1 commit intojquery:masterfrom
Closed
Dialog: modified _createOverlay to _appendTo instead of document.body. F...#894djQuery wants to merge 1 commit intojquery:masterfrom
djQuery wants to merge 1 commit intojquery:masterfrom
Conversation
…. Fixed #8984 - Modal dialogs display behind overlay when using appendTo option
Member
|
@djQuery, thanks for contributing! In order for me to land this patch, you'll need to sign our CLA: http://jquery.github.com/cla.html @jzaefferer, this looks good to me. Please confirm. |
Member
|
Everything looks good now, thanks @djQuery. @mikesherov He already signed the CLA, but we'll need to edit his name in the git commit. |
Member
|
Thanks! Landed in 55360ee. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dialog: modified _createOverlay to _appendTo instead of document.body. Fixed #8984 - Modal dialogs display behind overlay when using appendTo option