[1.11] Widget: Implement instance method on the bridge to return widget instance#902
Closed
gnarf wants to merge 3 commits into
Closed
[1.11] Widget: Implement instance method on the bridge to return widget instance#902gnarf wants to merge 3 commits into
gnarf wants to merge 3 commits into
Conversation
Member
|
@gnarf37 Can you rebase this? We're ready to land it in master. |
…ance - Fixes #9030 - `instance` method in widget prototype
Member
Author
|
rebased |
Member
There was a problem hiding this comment.
This seems to need more changes, the demo is broken. Shows the select element and throws Uncaught ReferenceError: input is not defined at combobox.html:95
Member
There was a problem hiding this comment.
Rebase again? Both of those errors were fixed in the past few days.
Member
|
Reviewed. Found one broken demo and a very basic issue, see comments above. Otherwise looking good. |
Member
|
Replaced by #939 with a branch within this repo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A new method on the widget bridge that gives you access to the widget instance without relying on the location it's stored in data not changing.
Not implemented exactly like the ticket described, but there was some fun logic in the bridge that needed to be overridden to make it return
instance.http://jqbug.com/ui/9030